Reintroduce plumbing for user gesture into permission system.

Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

TBR=torne@chromium.org
BUG=614599
Committed: https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e
Cr-Commit-Position: refs/heads/master@{#403738}

[benwells, 2016-07-01 01:11:05]

benwells@chromium.org changed reviewers:
+ dominickn@chromium.org

[benwells, 2016-07-01 01:11:06]

dominickn for first pass

[dominickn, 2016-07-01 01:28:29]

non-OWNER lgtm % nits

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/permissi...
File chrome/browser/permissions/permission_context_base_unittest.cc (right):

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/permissi...
chrome/browser/permissions/permission_context_base_unittest.cc:156: id, url,
true,
Nit: add /* user gesture */ comments?

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/push_mes...
File chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
(right):

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/push_mes...
chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc:205:
true, callback);
Nit: add /* user_gesture */

https://codereview.chromium.org/2110343002/diff/60001/content/browser/permiss...
File content/browser/permissions/permission_service_impl.cc (right):

https://codereview.chromium.org/2110343002/diff/60001/content/browser/permiss...
content/browser/permissions/permission_service_impl.cc:141: user_gesture, //
TODO(mlamouri): should be removed (crbug.com/423770)
Remove this TODO?

https://codereview.chromium.org/2110343002/diff/60001/content/browser/permiss...
content/browser/permissions/permission_service_impl.cc:202: user_gesture, //
TODO(mlamouri): should be removed (crbug.com/423770)
Remove TODO

[benwells, 2016-07-01 01:56:28]

benwells@chromium.org changed reviewers:
+ halliwell@chromium.org, jochen@chromium.org, torne@chromium.org,
wez@chromium.org

[benwells, 2016-07-01 01:56:29]

+jochen for chrome/ and content/ owner
+torne for android
+halliwell for chromecast
+wez for blimp

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/permissi...
File chrome/browser/permissions/permission_context_base_unittest.cc (right):

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/permissi...
chrome/browser/permissions/permission_context_base_unittest.cc:156: id, url,
true,
On 2016/07/01 01:28:28, dominickn wrote:
> Nit: add /* user gesture */ comments?

Done.

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/push_mes...
File chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
(right):

https://codereview.chromium.org/2110343002/diff/60001/chrome/browser/push_mes...
chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc:205:
true, callback);
On 2016/07/01 01:28:28, dominickn wrote:
> Nit: add /* user_gesture */

Done.

https://codereview.chromium.org/2110343002/diff/60001/content/browser/permiss...
File content/browser/permissions/permission_service_impl.cc (right):

https://codereview.chromium.org/2110343002/diff/60001/content/browser/permiss...
content/browser/permissions/permission_service_impl.cc:141: user_gesture, //
TODO(mlamouri): should be removed (crbug.com/423770)
On 2016/07/01 01:28:28, dominickn wrote:
> Remove this TODO?

Done.

https://codereview.chromium.org/2110343002/diff/60001/content/browser/permiss...
content/browser/permissions/permission_service_impl.cc:202: user_gesture, //
TODO(mlamouri): should be removed (crbug.com/423770)
On 2016/07/01 01:28:29, dominickn wrote:
> Remove TODO

Done.

[Wez, 2016-07-01 03:28:34]

blimp/ LGTM

[halliwell, 2016-07-01 03:33:04]

On 2016/07/01 03:28:34, Wez wrote:
> blimp/ LGTM

chromecast/ lgtm

[jochen (gone - plz use gerrit), 2016-07-01 14:14:58]

lgtm

[benwells, 2016-07-05 03:02:17]

Description was changed from

==========
Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

BUG=614599
==========

to

==========
Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

TBR=torne@chromium.org
BUG=614599
==========

[benwells, 2016-07-05 03:02:52]

moving torne@ to TBR as the android_webview changes are refactoring fallout.

[benwells, 2016-07-05 03:03:00]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-07-05 03:03:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2110343002/#ps80001
(title: "Nits")

[commit-bot: I haz the power, 2016-07-05 03:03:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 04:27:07]

Description was changed from

==========
Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

TBR=torne@chromium.org
BUG=614599
==========

to

==========
Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

TBR=torne@chromium.org
BUG=614599
==========

[commit-bot: I haz the power, 2016-07-05 04:27:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-05 04:28:45]

Description was changed from

==========
Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

TBR=torne@chromium.org
BUG=614599
==========

to

==========
Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

TBR=torne@chromium.org
BUG=614599

Committed: https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e
Cr-Commit-Position: refs/heads/master@{#403738}
==========

[commit-bot: I haz the power, 2016-07-05 04:28:47]

Patchset 5 (id:??) landed as
https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e
Cr-Commit-Position: refs/heads/master@{#403738}

[Torne, 2016-07-08 10:03:39]

android_webview LGTM