blimp/engine/app/blimp_permission_manager.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/app/blimp_permission_manager.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/engine/app/blimp_permission_manager.h ('k') | chrome/browser/background_sync/background_sync_permission_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/app/blimp_permission_manager.cc

diff --git a/blimp/engine/app/blimp_permission_manager.cc b/blimp/engine/app/blimp_permission_manager.cc

index 7e4b7b20736d12a9e03aeb8921009a2f1e678d23..6f48b00325aa4ba6d5a8315d4b0ccc2ca6859eca 100644

--- a/blimp/engine/app/blimp_permission_manager.cc

+++ b/blimp/engine/app/blimp_permission_manager.cc

@@ -21,6 +21,7 @@ int BlimpPermissionManager::RequestPermission(

content::PermissionType permission,

content::RenderFrameHost* render_frame_host,

const GURL& origin,

+ bool user_gesture,

const base::Callback<void(blink::mojom::PermissionStatus)>& callback) {

callback.Run(blink::mojom::PermissionStatus::DENIED);

return kNoPendingOperation;

@@ -30,6 +31,7 @@ int BlimpPermissionManager::RequestPermissions(

const std::vector<content::PermissionType>& permission,

content::RenderFrameHost* render_frame_host,

const GURL& requesting_origin,

+ bool user_gesture,

const base::Callback<

void(const std::vector<blink::mojom::PermissionStatus>&)>& callback) {

callback.Run(std::vector<blink::mojom::PermissionStatus>(

« no previous file with comments | « blimp/engine/app/blimp_permission_manager.h ('k') | chrome/browser/background_sync/background_sync_permission_context.h » ('j') | no next file with comments »