content/browser/permissions/permission_service_impl.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/cast_permission_manager.cc ('k') | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/permissions/permission_service_impl.cc

diff --git a/content/browser/permissions/permission_service_impl.cc b/content/browser/permissions/permission_service_impl.cc

index 39daa6434744e97e8fde6e6cbefb1aee0ee1ba90..e45064030ab5e417a5278323c7f3f58e90b0d3d6 100644

--- a/content/browser/permissions/permission_service_impl.cc

+++ b/content/browser/permissions/permission_service_impl.cc

@@ -138,6 +138,7 @@ void PermissionServiceImpl::RequestPermission(

PermissionNameToPermissionType(permission),

context_->render_frame_host(),

GURL(origin.get()),

+ user_gesture,

base::Bind(&PermissionServiceImpl::OnRequestPermissionResponse,

weak_factory_.GetWeakPtr(),

pending_request_id));

@@ -198,6 +199,7 @@ void PermissionServiceImpl::RequestPermissions(

types,

context_->render_frame_host(),

GURL(origin.get()),

+ user_gesture,

base::Bind(&PermissionServiceImpl::OnRequestPermissionsResponse,

weak_factory_.GetWeakPtr(),

pending_request_id));

« no previous file with comments | « chromecast/browser/cast_permission_manager.cc ('k') | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »