chrome/browser/permissions/permission_context_base.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_context_base.h ('k') | chrome/browser/permissions/permission_context_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_context_base.cc

diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc

index 74691a47252c1499c26da3613e256769238fe092..093f6b253c6dff5eb073d1da66f5a56dd17375ce 100644

--- a/chrome/browser/permissions/permission_context_base.cc

+++ b/chrome/browser/permissions/permission_context_base.cc

@@ -61,6 +61,7 @@ void PermissionContextBase::RequestPermission(

content::WebContents* web_contents,

const PermissionRequestID& id,

const GURL& requesting_frame,

+ bool user_gesture,

const BrowserPermissionCallback& callback) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

@@ -112,7 +113,7 @@ void PermissionContextBase::RequestPermission(

embedding_origin, profile_);

DecidePermission(web_contents, id, requesting_origin, embedding_origin,

- callback);

+ user_gesture, callback);

}

ContentSetting PermissionContextBase::GetPermissionStatus(

@@ -164,6 +165,7 @@ void PermissionContextBase::DecidePermission(

const PermissionRequestID& id,

const GURL& requesting_origin,

const GURL& embedding_origin,

+ bool user_gesture,

const BrowserPermissionCallback& callback) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);