Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h" 5 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 bool user_gesture, 264 bool user_gesture,
265 bool last_unlocked_by_target, 265 bool last_unlocked_by_target,
266 const base::Callback<void(bool)>& callback) { 266 const base::Callback<void(bool)>& callback) {
267 web_view_permission_helper_delegate_->RequestPointerLockPermission( 267 web_view_permission_helper_delegate_->RequestPointerLockPermission(
268 user_gesture, last_unlocked_by_target, callback); 268 user_gesture, last_unlocked_by_target, callback);
269 } 269 }
270 270
271 void WebViewPermissionHelper::RequestGeolocationPermission( 271 void WebViewPermissionHelper::RequestGeolocationPermission(
272 int bridge_id, 272 int bridge_id,
273 const GURL& requesting_frame, 273 const GURL& requesting_frame,
274 bool user_gesture,
274 const base::Callback<void(bool)>& callback) { 275 const base::Callback<void(bool)>& callback) {
275 web_view_permission_helper_delegate_->RequestGeolocationPermission( 276 web_view_permission_helper_delegate_->RequestGeolocationPermission(
276 bridge_id, requesting_frame, callback); 277 bridge_id, requesting_frame, user_gesture, callback);
277 } 278 }
278 279
279 void WebViewPermissionHelper::CancelGeolocationPermissionRequest( 280 void WebViewPermissionHelper::CancelGeolocationPermissionRequest(
280 int bridge_id) { 281 int bridge_id) {
281 web_view_permission_helper_delegate_->CancelGeolocationPermissionRequest( 282 web_view_permission_helper_delegate_->CancelGeolocationPermissionRequest(
282 bridge_id); 283 bridge_id);
283 } 284 }
284 285
285 void WebViewPermissionHelper::RequestFileSystemPermission( 286 void WebViewPermissionHelper::RequestFileSystemPermission(
286 const GURL& url, 287 const GURL& url,
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 allowed_by_default(allowed_by_default) { 407 allowed_by_default(allowed_by_default) {
407 } 408 }
408 409
409 WebViewPermissionHelper::PermissionResponseInfo::PermissionResponseInfo( 410 WebViewPermissionHelper::PermissionResponseInfo::PermissionResponseInfo(
410 const PermissionResponseInfo& other) = default; 411 const PermissionResponseInfo& other) = default;
411 412
412 WebViewPermissionHelper::PermissionResponseInfo::~PermissionResponseInfo() { 413 WebViewPermissionHelper::PermissionResponseInfo::~PermissionResponseInfo() {
413 } 414 }
414 415
415 } // namespace extensions 416 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698