chrome/browser/permissions/permission_context_base.h - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_context_base.h

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_permission_context_unittest.cc ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_context_base.h

diff --git a/chrome/browser/permissions/permission_context_base.h b/chrome/browser/permissions/permission_context_base.h

index e7257edde83178a974f549bdabc4e44371998573..d8ca742f24114a52e00ecf93d43f16fc844430c0 100644

--- a/chrome/browser/permissions/permission_context_base.h

+++ b/chrome/browser/permissions/permission_context_base.h

@@ -79,6 +79,7 @@ class PermissionContextBase : public KeyedService {

virtual void RequestPermission(content::WebContents* web_contents,

const PermissionRequestID& id,

const GURL& requesting_frame,

+ bool user_gesture,

const BrowserPermissionCallback& callback);

// Returns whether the permission has been granted, denied...

@@ -108,6 +109,7 @@ class PermissionContextBase : public KeyedService {

const PermissionRequestID& id,

const GURL& requesting_origin,

const GURL& embedding_origin,

+ bool user_gesture,

const BrowserPermissionCallback& callback);

// Called when permission is granted without interactively asking the user.