chrome/browser/notifications/notification_permission_context_unittest.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_context_unittest.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_permission_context.cc ('k') | chrome/browser/permissions/permission_context_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_context_unittest.cc

diff --git a/chrome/browser/notifications/notification_permission_context_unittest.cc b/chrome/browser/notifications/notification_permission_context_unittest.cc

index 0aa58db82cbea7f4f891a9f2ed41715513390e6c..6ae74b526918de636d79377bd890d53dd7032dfc 100644

--- a/chrome/browser/notifications/notification_permission_context_unittest.cc

+++ b/chrome/browser/notifications/notification_permission_context_unittest.cc

@@ -162,7 +162,7 @@ TEST_F(NotificationPermissionContextTest, TestDenyInIncognitoAfterDelay) {

permission_context.last_permission_set_setting());

permission_context.RequestPermission(

- web_contents(), id, url, base::Bind(&DoNothing));

+ web_contents(), id, url, true /* user_gesture */, base::Bind(&DoNothing));

// Should be blocked after 1-2 seconds, but the timer is reset whenever the

// tab is not visible, so these 500ms never add up to >= 1 second.

@@ -231,7 +231,7 @@ TEST_F(NotificationPermissionContextTest, TestCancelledIncognitoRequest) {

// failing, PermissionManager::OnPermissionsRequestResponseStatus will crash.

int request_id = permission_manager->RequestPermission(

content::PermissionType::NOTIFICATIONS, web_contents()->GetMainFrame(),

- url.GetOrigin(), base::Bind(&DoNothing2));

+ url.GetOrigin(), true /* user_gesture */, base::Bind(&DoNothing2));

permission_manager->CancelPermissionRequest(request_id);

@@ -265,8 +265,10 @@ TEST_F(NotificationPermissionContextTest, TestParallelDenyInIncognito) {

permission_context.last_permission_set_setting());

permission_context.RequestPermission(web_contents(), id0, url,

+ true /* user_gesture */,

base::Bind(&DoNothing));

permission_context.RequestPermission(web_contents(), id1, url,

+ true /* user_gesture */,

base::Bind(&DoNothing));

EXPECT_EQ(0, permission_context.permission_set_count());