chrome/browser/push_messaging/push_messaging_permission_context.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_permission_context.h ('k') | chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_permission_context.cc

diff --git a/chrome/browser/push_messaging/push_messaging_permission_context.cc b/chrome/browser/push_messaging/push_messaging_permission_context.cc

index f5591c26faeba9bab26117e7fa51b77fbf57bd05..a7a786f10f93a947012fa81970954e2fd65a2ae5 100644

--- a/chrome/browser/push_messaging/push_messaging_permission_context.cc

+++ b/chrome/browser/push_messaging/push_messaging_permission_context.cc

@@ -75,6 +75,7 @@ void PushMessagingPermissionContext::DecidePermission(

const PermissionRequestID& id,

const GURL& requesting_origin,

const GURL& embedding_origin,

+ bool user_gesture,

const BrowserPermissionCallback& callback) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

#if defined(ENABLE_NOTIFICATIONS)

@@ -86,7 +87,7 @@ void PushMessagingPermissionContext::DecidePermission(

PermissionManager::Get(profile_)->RequestPermission(

content::PermissionType::NOTIFICATIONS, web_contents->GetMainFrame(),

- requesting_origin,

+ requesting_origin, user_gesture,

base::Bind(&PushMessagingPermissionContext::DecidePushPermission,

weak_factory_ui_thread_.GetWeakPtr(), id, requesting_origin,

embedding_origin, callback));