chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_permission_context.cc ('k') | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

diff --git a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

index e77c100eb0233e5dbee2e62e27b3e290c4c38388..f063f638257513a4e69fc23f6b26508e742c0a7b 100644

--- a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

+++ b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

@@ -202,14 +202,14 @@ TEST_F(PushMessagingPermissionContextTest, DecidePermission) {

// Requesting and embedding origin are different.

context.DecidePermission(NULL, request_id, GURL(kOriginA), GURL(kOriginB),

- callback);

+ true /* user_gesture */, callback);

EXPECT_FALSE(context.was_persisted());

EXPECT_FALSE(context.was_granted());

// Insecure origin

NavigateAndCommit(GURL(kInsecureOrigin));

context.RequestPermission(web_contents(), request_id, GURL(kInsecureOrigin),

- callback);

+ true /* user_gesture */, callback);

EXPECT_FALSE(context.was_persisted());

EXPECT_FALSE(context.was_granted());

}

@@ -235,7 +235,7 @@ TEST_F(PushMessagingPermissionContextTest, RequestPermission) {

// silently assumed to be granted.

NavigateAndCommit(GURL(kOriginA));

context.RequestPermission(web_contents(), request_id, GURL(kOriginA),

- callback);

+ true /* user_gesture */, callback);

// Although the permission check goes through, the push message permission

// isn't actually updated.

@@ -260,7 +260,7 @@ TEST_F(PushMessagingPermissionContextTest, RequestAfterRevokingNotifications) {

NavigateAndCommit(GURL(kOriginA));

context.RequestPermission(web_contents(), request_id, GURL(kOriginA),

- callback);

+ true /* user_gesture */, callback);

EXPECT_TRUE(context.was_granted());

EXPECT_EQ(CONTENT_SETTING_ALLOW,

@@ -275,7 +275,7 @@ TEST_F(PushMessagingPermissionContextTest, RequestAfterRevokingNotifications) {

context.GetPermissionStatus(GURL(kOriginA), GURL(kOriginA)));

context.RequestPermission(web_contents(), request_id, GURL(kOriginA),

- callback);

+ true /* user_gesture */, callback);

EXPECT_FALSE(context.was_persisted());

EXPECT_FALSE(context.was_granted());

EXPECT_EQ(CONTENT_SETTING_BLOCK,