chrome/browser/geolocation/geolocation_permission_context_extensions.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_extensions.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_extensions.h ('k') | chrome/browser/geolocation/geolocation_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_extensions.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

index 58944f060001564470d1fa7f9352113cfbf626ae..d92f7ee6be4f5bbb359eeb89fdb0cee79b7cbf8d 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

@@ -49,6 +49,7 @@ bool GeolocationPermissionContextExtensions::DecidePermission(

const PermissionRequestID& request_id,

int bridge_id,

const GURL& requesting_frame,

+ bool user_gesture,

const base::Callback<void(ContentSetting)>& callback,

bool* permission_set,

bool* new_permission) {

@@ -59,7 +60,7 @@ bool GeolocationPermissionContextExtensions::DecidePermission(

extensions::WebViewPermissionHelper::FromWebContents(web_contents);

if (web_view_permission_helper) {

web_view_permission_helper->RequestGeolocationPermission(

- bridge_id, requesting_frame,

+ bridge_id, requesting_frame, user_gesture,

base::Bind(&CallbackContentSettingWrapper, callback));

*permission_set = false;

*new_permission = false;