chrome/browser/notifications/notification_permission_context.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_context.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_permission_context.h ('k') | chrome/browser/notifications/notification_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_context.cc

diff --git a/chrome/browser/notifications/notification_permission_context.cc b/chrome/browser/notifications/notification_permission_context.cc

index 8a90344ca0328c6cd97e829518c3a442b15e8ed5..89ae620b21f2d6ed9cd8c29f1066d84bdb797e80 100644

--- a/chrome/browser/notifications/notification_permission_context.cc

+++ b/chrome/browser/notifications/notification_permission_context.cc

@@ -188,6 +188,7 @@ void NotificationPermissionContext::DecidePermission(

const PermissionRequestID& id,

const GURL& requesting_origin,

const GURL& embedding_origin,

+ bool user_gesture,

const BrowserPermissionCallback& callback) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

@@ -214,7 +215,8 @@ void NotificationPermissionContext::DecidePermission(

}

PermissionContextBase::DecidePermission(web_contents, id, requesting_origin,

- embedding_origin, callback);

+ embedding_origin, user_gesture,

+ callback);

}

// Unlike other permission types, granting a notification for a given origin