chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_unittest.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

index d033a310b0e8eed4685c8b054150018006cfc6fa..64a21c95c34660bd387033e3350dbacaa1071824 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

@@ -31,6 +31,7 @@ class ChromeWebViewPermissionHelperDelegate :

void RequestGeolocationPermission(

int bridge_id,

const GURL& requesting_frame,

+ bool user_gesture,

const base::Callback<void(bool)>& callback) override;

void CancelGeolocationPermissionRequest(int bridge_id) override;

void RequestFileSystemPermission(

@@ -76,6 +77,7 @@ class ChromeWebViewPermissionHelperDelegate :

void OnGeolocationPermissionResponse(

int bridge_id,

+ bool user_gesture,

const base::Callback<void(blink::mojom::PermissionStatus)>& callback,

bool allow,

const std::string& user_input);