extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h

index eea7ad4d94dcf49896c5f89235fc4ecf09d56efa..4f2bdd1a20081c8cdcae4702e87dc7c9b43407bf 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h

@@ -35,6 +35,7 @@ class WebViewPermissionHelperDelegate : public content::WebContentsObserver {

virtual void RequestGeolocationPermission(

int bridge_id,

const GURL& requesting_frame,

+ bool user_gesture,

const base::Callback<void(bool)>& callback) {}

virtual void CancelGeolocationPermissionRequest(int bridge_id) {}

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_permission_helper.cc ('k') | no next file » | no next file with comments »