chrome/browser/geolocation/geolocation_permission_context_android.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_android.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_android.h ('k') | chrome/browser/geolocation/geolocation_permission_context_extensions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_android.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_android.cc b/chrome/browser/geolocation/geolocation_permission_context_android.cc

index cabc47409f5772a7a94496999a904cce7af23b81..5932f06f407f63c644fdc83c01b3ddd21135587c 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_android.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_android.cc

@@ -32,6 +32,7 @@ void GeolocationPermissionContextAndroid::RequestPermission(

content::WebContents* web_contents,

const PermissionRequestID& id,

const GURL& requesting_frame_origin,

+ bool user_gesture,

const BrowserPermissionCallback& callback) {

if (!location_settings_->CanSitesRequestLocationPermission(web_contents)) {

PermissionDecided(id, requesting_frame_origin,

@@ -61,7 +62,7 @@ void GeolocationPermissionContextAndroid::RequestPermission(

}

GeolocationPermissionContext::RequestPermission(

- web_contents, id, requesting_frame_origin, callback);

+ web_contents, id, requesting_frame_origin, user_gesture, callback);

}

void GeolocationPermissionContextAndroid::CancelPermissionRequest(