Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_PERMISSION_HELPER_DEL EGATE_H_ 5 #ifndef CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_PERMISSION_HELPER_DEL EGATE_H_
6 #define CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_PERMISSION_HELPER_DEL EGATE_H_ 6 #define CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_PERMISSION_HELPER_DEL EGATE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h" 9 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
10 #include "extensions/browser/guest_view/web_view/web_view_permission_helper_dele gate.h" 10 #include "extensions/browser/guest_view/web_view/web_view_permission_helper_dele gate.h"
(...skipping 13 matching lines...) Expand all
24 void CanDownload(const GURL& url, 24 void CanDownload(const GURL& url,
25 const std::string& request_method, 25 const std::string& request_method,
26 const base::Callback<void(bool)>& callback) override; 26 const base::Callback<void(bool)>& callback) override;
27 void RequestPointerLockPermission( 27 void RequestPointerLockPermission(
28 bool user_gesture, 28 bool user_gesture,
29 bool last_unlocked_by_target, 29 bool last_unlocked_by_target,
30 const base::Callback<void(bool)>& callback) override; 30 const base::Callback<void(bool)>& callback) override;
31 void RequestGeolocationPermission( 31 void RequestGeolocationPermission(
32 int bridge_id, 32 int bridge_id,
33 const GURL& requesting_frame, 33 const GURL& requesting_frame,
34 bool user_gesture,
34 const base::Callback<void(bool)>& callback) override; 35 const base::Callback<void(bool)>& callback) override;
35 void CancelGeolocationPermissionRequest(int bridge_id) override; 36 void CancelGeolocationPermissionRequest(int bridge_id) override;
36 void RequestFileSystemPermission( 37 void RequestFileSystemPermission(
37 const GURL& url, 38 const GURL& url,
38 bool allowed_by_default, 39 bool allowed_by_default,
39 const base::Callback<void(bool)>& callback) override; 40 const base::Callback<void(bool)>& callback) override;
40 void FileSystemAccessedAsync(int render_process_id, 41 void FileSystemAccessedAsync(int render_process_id,
41 int render_frame_id, 42 int render_frame_id,
42 int request_id, 43 int request_id,
43 const GURL& url, 44 const GURL& url,
(...skipping 25 matching lines...) Expand all
69 void OnRemovePluginPlaceholderHost(int placeholder_id); 70 void OnRemovePluginPlaceholderHost(int placeholder_id);
70 #endif // defined(ENABLE_PLUGIN_INSTALLATION) 71 #endif // defined(ENABLE_PLUGIN_INSTALLATION)
71 72
72 void OnPermissionResponse(const std::string& identifier, 73 void OnPermissionResponse(const std::string& identifier,
73 bool allow, 74 bool allow,
74 const std::string& user_input); 75 const std::string& user_input);
75 #endif // defined(ENABLE_PLUGINS) 76 #endif // defined(ENABLE_PLUGINS)
76 77
77 void OnGeolocationPermissionResponse( 78 void OnGeolocationPermissionResponse(
78 int bridge_id, 79 int bridge_id,
80 bool user_gesture,
79 const base::Callback<void(blink::mojom::PermissionStatus)>& callback, 81 const base::Callback<void(blink::mojom::PermissionStatus)>& callback,
80 bool allow, 82 bool allow,
81 const std::string& user_input); 83 const std::string& user_input);
82 84
83 void OnFileSystemPermissionResponse( 85 void OnFileSystemPermissionResponse(
84 const base::Callback<void(bool)>& callback, 86 const base::Callback<void(bool)>& callback,
85 bool allow, 87 bool allow,
86 const std::string& user_input); 88 const std::string& user_input);
87 89
88 void OnDownloadPermissionResponse( 90 void OnDownloadPermissionResponse(
(...skipping 30 matching lines...) Expand all
119 std::map<int, int> bridge_id_to_request_id_map_; 121 std::map<int, int> bridge_id_to_request_id_map_;
120 122
121 base::WeakPtrFactory<ChromeWebViewPermissionHelperDelegate> weak_factory_; 123 base::WeakPtrFactory<ChromeWebViewPermissionHelperDelegate> weak_factory_;
122 124
123 DISALLOW_COPY_AND_ASSIGN(ChromeWebViewPermissionHelperDelegate); 125 DISALLOW_COPY_AND_ASSIGN(ChromeWebViewPermissionHelperDelegate);
124 }; 126 };
125 127
126 } // namespace extensions 128 } // namespace extensions
127 129
128 #endif // CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_PERMISSION_HELPER_ DELEGATE_H_ 130 #endif // CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_PERMISSION_HELPER_ DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698