Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: chrome/browser/permissions/permission_context_base_unittest.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base_unittest.cc
diff --git a/chrome/browser/permissions/permission_context_base_unittest.cc b/chrome/browser/permissions/permission_context_base_unittest.cc
index 87a84bc19e5f5e7f4699e29b5c38fc3f0fb46de7..62d3bd884d88c7de3f77e80b2b6866f52deeef50 100644
--- a/chrome/browser/permissions/permission_context_base_unittest.cc
+++ b/chrome/browser/permissions/permission_context_base_unittest.cc
@@ -152,7 +152,8 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
web_contents()->GetMainFrame()->GetRoutingID(),
-1);
permission_context.RequestPermission(
- web_contents(), id, url,
+ web_contents(),
+ id, url, true /* user_gesture */,
base::Bind(&TestPermissionContext::TrackPermissionDecision,
base::Unretained(&permission_context)));
@@ -176,7 +177,8 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
web_contents()->GetMainFrame()->GetRoutingID(),
-1);
permission_context.RequestPermission(
- web_contents(), id, url,
+ web_contents(),
+ id, url, true /* user_gesture */,
base::Bind(&TestPermissionContext::TrackPermissionDecision,
base::Unretained(&permission_context)));
@@ -202,7 +204,8 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
web_contents()->GetMainFrame()->GetRoutingID(),
-1);
permission_context.RequestPermission(
- web_contents(), id, url,
+ web_contents(),
+ id, url, true /* user_gesture */,
base::Bind(&TestPermissionContext::TrackPermissionDecision,
base::Unretained(&permission_context)));
@@ -226,7 +229,8 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
web_contents()->GetMainFrame()->GetRoutingID(),
-1);
permission_context.RequestPermission(
- web_contents(), id, url,
+ web_contents(),
+ id, url, true /* user_gesture */,
base::Bind(&TestPermissionContext::TrackPermissionDecision,
base::Unretained(&permission_context)));
@@ -283,11 +287,11 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
web_contents()->GetMainFrame()->GetRoutingID(), 1);
permission_context.RequestPermission(
- web_contents(), id0, url,
+ web_contents(), id0, url, true /* user_gesture */,
base::Bind(&TestPermissionContext::TrackPermissionDecision,
base::Unretained(&permission_context)));
permission_context.RequestPermission(
- web_contents(), id1, url,
+ web_contents(), id1, url, true /* user_gesture */,
base::Bind(&TestPermissionContext::TrackPermissionDecision,
base::Unretained(&permission_context)));
« no previous file with comments | « chrome/browser/permissions/permission_context_base.cc ('k') | chrome/browser/permissions/permission_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698