Change WebContentsDelegate::RunFileChooser to be frame based.

Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/35169afd1ede3dc971194e7cef278e7bb9c02a4d
Cr-Commit-Position: refs/heads/master@{#399240}

[nasko, 2016-06-09 22:23:30]

Description was changed from

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
==========

to

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-06-09 23:02:10]

nasko@chromium.org changed reviewers:
+ alexmos@chromium.org

[nasko, 2016-06-09 23:02:11]

Hey Alex,
Can you review this CL for me? It is one part of moving the file chooser to be
OOPIF compatible.
Thanks in advance!
Nasko

[nasko, 2016-06-10 14:08:21]

nasko@chromium.org changed reviewers:
+ avi@chromium.org

[nasko, 2016-06-10 14:08:22]

Avi, do you mind doing the honors of initial pass?

[Avi (use Gerrit), 2016-06-10 14:45:14]

lgtm

This looks completely reasonable. I imagine there will be a second pass to move
the Blink-level calls to WebFrameClient?

https://codereview.chromium.org/2059533002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2059533002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:2626:
render_view_host_->FilesSelectedInChooser(files, permissions);
Eventually you move this to RFHI too?

[nasko, 2016-06-10 14:50:21]

On 2016/06/10 14:45:14, Avi (OOO 12 June - 25 June) wrote:
> lgtm
> 
> This looks completely reasonable. I imagine there will be a second pass to
move
> the Blink-level calls to WebFrameClient?

Yes, it is done at https://codereview.chromium.org/2050623005/, but I'm
splitting reasonable parts to land separately to decrease the complexity of the
reviews.

[nasko, 2016-06-10 14:50:33]

https://codereview.chromium.org/2059533002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2059533002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:2626:
render_view_host_->FilesSelectedInChooser(files, permissions);
On 2016/06/10 14:45:14, Avi (OOO 12 June - 25 June) wrote:
> Eventually you move this to RFHI too?

Indeed. This is just split off from https://codereview.chromium.org/2050623005/.

[nasko, 2016-06-10 14:56:39]

nasko@chromium.org changed reviewers:
+ asargent@chromium.org, sgurun@chromium.org

[nasko, 2016-06-10 14:56:40]

Please do OWNERS reviews:

asargent@ -> extensions and apps
sgurun@ -> android_webview
dgozman@ -> devtools
lfg@ -> guest_view
dtrainor@ -> chrome/browser/android
thestig@ -> overall chrome/

[nasko, 2016-06-10 15:02:03]

nasko@chromium.org changed reviewers:
+ dtrainor@chromium.org, thestig@chromium.org

[nasko, 2016-06-10 15:02:04]

Actually adding dtrainor@ and thestig@.

[nasko, 2016-06-10 15:04:49]

Description was changed from

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-06-10 15:04:49]

nasko@chromium.org changed reviewers:
+ lfg@chromium.org

[David Trainor- moved to gerrit, 2016-06-10 16:09:16]

chrome/browser/android lgtm!

[asargent_no_longer_on_chrome, 2016-06-10 17:00:22]

extensions and apps changes lgtm

[Lei Zhang, 2016-06-10 17:02:41]

lgtm

https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
File chrome/browser/file_select_helper.cc (right):

https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
chrome/browser/file_select_helper.cc:307: ->GetFileSystemContext();
Is this clang-format's choosing? Maybe have a local variable for the
SiteInstance and reuse on line 310?

[wjmaclean, 2016-06-10 17:04:25]

On 2016/06/10 17:02:41, Lei Zhang (Slow) wrote:
> lgtm
> 
>
https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
> File chrome/browser/file_select_helper.cc (right):
> 
>
https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
> chrome/browser/file_select_helper.cc:307: ->GetFileSystemContext();
> Is this clang-format's choosing? Maybe have a local variable for the
> SiteInstance and reuse on line 310?

components/guestview lgtm

[sgurun-gerrit only, 2016-06-10 17:16:25]

On 2016/06/10 17:04:25, wjmaclean wrote:
> On 2016/06/10 17:02:41, Lei Zhang (Slow) wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
> > File chrome/browser/file_select_helper.cc (right):
> > 
> >
>
https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
> > chrome/browser/file_select_helper.cc:307: ->GetFileSystemContext();
> > Is this clang-format's choosing? Maybe have a local variable for the
> > SiteInstance and reuse on line 310?
> 
> components/guestview lgtm

aw lgtm

[nasko, 2016-06-10 17:19:09]

https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
File chrome/browser/file_select_helper.cc (right):

https://codereview.chromium.org/2059533002/diff/20001/chrome/browser/file_sel...
chrome/browser/file_select_helper.cc:307: ->GetFileSystemContext();
On 2016/06/10 17:02:41, Lei Zhang (Slow) wrote:
> Is this clang-format's choosing? Maybe have a local variable for the
> SiteInstance and reuse on line 310?

Yes, indeed this is clang-format.

[nasko, 2016-06-10 17:19:21]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-06-10 17:19:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org,
dtrainor@chromium.org, wjmaclean@chromium.org, thestig@chromium.org,
avi@chromium.org, asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2059533002/#ps40001
(title: "Fixes based on reviews.")

[commit-bot: I haz the power, 2016-06-10 17:19:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059533002/40001

[commit-bot: I haz the power, 2016-06-10 18:47:28]

Description was changed from

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-06-10 18:47:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 18:47:39]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 18:49:22]

Description was changed from

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change WebContentsDelegate::RunFileChooser to be frame based.

The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.

BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/35169afd1ede3dc971194e7cef278e7bb9c02a4d
Cr-Commit-Position: refs/heads/master@{#399240}
==========

[commit-bot: I haz the power, 2016-06-10 18:49:24]

Patchset 3 (id:??) landed as
https://crrev.com/35169afd1ede3dc971194e7cef278e7bb9c02a4d
Cr-Commit-Position: refs/heads/master@{#399240}