content/browser/frame_host/render_frame_host_impl.cc - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 9bcbd30013e23eb7352c5c10589aaf2eb69ffcbd..970dd244768f9f27637a756ac5e2cb2c447ed536 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -76,6 +76,8 @@

#include "content/public/common/browser_side_navigation_policy.h"

#include "content/public/common/content_constants.h"

#include "content/public/common/content_switches.h"

+#include "content/public/common/file_chooser_file_info.h"

+#include "content/public/common/file_chooser_params.h"

#include "content/public/common/isolated_world_ids.h"

#include "content/public/common/url_constants.h"

#include "content/public/common/url_utils.h"

@@ -2618,6 +2620,12 @@ int RenderFrameHostImpl::GetProxyCount() {

return frame_tree_node_->render_manager()->GetProxyCount();

}

+void RenderFrameHostImpl::FilesSelectedInChooser(

+ const std::vector<content::FileChooserFileInfo>& files,

+ FileChooserParams::Mode permissions) {

+ render_view_host_->FilesSelectedInChooser(files, permissions);

#if defined(USE_EXTERNAL_POPUP_MENU)

#if defined(OS_MACOSX)