apps/custom_launcher_page_contents.h - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/custom_launcher_page_contents.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/custom_launcher_page_contents.h

diff --git a/apps/custom_launcher_page_contents.h b/apps/custom_launcher_page_contents.h

index b5522873ebc2b39f5f52869783feccef6848d1bf..d08a2855a79b5ea17596b5413127a854559c6bd7 100644

--- a/apps/custom_launcher_page_contents.h

+++ b/apps/custom_launcher_page_contents.h

@@ -56,7 +56,7 @@ class CustomLauncherPageContents : public content::WebContentsDelegate {

content::WebContents* web_contents,

SkColor color,

const std::vector<content::ColorSuggestion>& suggestions) override;

- void RunFileChooser(content::WebContents* tab,

+ void RunFileChooser(content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) override;

void RequestToLockMouse(content::WebContents* web_contents,

bool user_gesture,

« no previous file with comments | « android_webview/native/aw_web_contents_delegate.cc ('k') | apps/custom_launcher_page_contents.cc » ('j') | no next file with comments »