chrome/browser/ui/apps/chrome_app_delegate.cc - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/chrome_app_delegate.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/apps/chrome_app_delegate.cc

diff --git a/chrome/browser/ui/apps/chrome_app_delegate.cc b/chrome/browser/ui/apps/chrome_app_delegate.cc

index 2dd00c721ce91ff5a3d93ff328b5d1f132cf6ac1..228df166ea7812dc272c6a14d368178f7fb3968f 100644

--- a/chrome/browser/ui/apps/chrome_app_delegate.cc

+++ b/chrome/browser/ui/apps/chrome_app_delegate.cc

@@ -256,9 +256,9 @@ content::ColorChooser* ChromeAppDelegate::ShowColorChooser(

}

void ChromeAppDelegate::RunFileChooser(

- content::WebContents* tab,

+ content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) {

- FileSelectHelper::RunFileChooser(tab, params);

+ FileSelectHelper::RunFileChooser(render_frame_host, params);

}

void ChromeAppDelegate::RequestMediaAccessPermission(

« no previous file with comments | « chrome/browser/ui/apps/chrome_app_delegate.h ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »