Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: chrome/browser/devtools/devtools_window.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h" 9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
10 #include "chrome/browser/devtools/devtools_toggle_action.h" 10 #include "chrome/browser/devtools/devtools_toggle_action.h"
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 bool* is_keyboard_shortcut) override; 287 bool* is_keyboard_shortcut) override;
288 void HandleKeyboardEvent( 288 void HandleKeyboardEvent(
289 content::WebContents* source, 289 content::WebContents* source,
290 const content::NativeWebKeyboardEvent& event) override; 290 const content::NativeWebKeyboardEvent& event) override;
291 content::JavaScriptDialogManager* GetJavaScriptDialogManager( 291 content::JavaScriptDialogManager* GetJavaScriptDialogManager(
292 content::WebContents* source) override; 292 content::WebContents* source) override;
293 content::ColorChooser* OpenColorChooser( 293 content::ColorChooser* OpenColorChooser(
294 content::WebContents* web_contents, 294 content::WebContents* web_contents,
295 SkColor color, 295 SkColor color,
296 const std::vector<content::ColorSuggestion>& suggestions) override; 296 const std::vector<content::ColorSuggestion>& suggestions) override;
297 void RunFileChooser(content::WebContents* web_contents, 297 void RunFileChooser(content::RenderFrameHost* render_frame_host,
298 const content::FileChooserParams& params) override; 298 const content::FileChooserParams& params) override;
299 bool PreHandleGestureEvent(content::WebContents* source, 299 bool PreHandleGestureEvent(content::WebContents* source,
300 const blink::WebGestureEvent& event) override; 300 const blink::WebGestureEvent& event) override;
301 301
302 // content::DevToolsUIBindings::Delegate overrides 302 // content::DevToolsUIBindings::Delegate overrides
303 void ActivateWindow() override; 303 void ActivateWindow() override;
304 void CloseWindow() override; 304 void CloseWindow() override;
305 void SetInspectedPageBounds(const gfx::Rect& rect) override; 305 void SetInspectedPageBounds(const gfx::Rect& rect) override;
306 void InspectElementCompleted() override; 306 void InspectElementCompleted() override;
307 void SetIsDocked(bool is_docked) override; 307 void SetIsDocked(bool is_docked) override;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 base::Closure ready_for_test_callback_; 343 base::Closure ready_for_test_callback_;
344 344
345 base::TimeTicks inspect_element_start_time_; 345 base::TimeTicks inspect_element_start_time_;
346 std::unique_ptr<DevToolsEventForwarder> event_forwarder_; 346 std::unique_ptr<DevToolsEventForwarder> event_forwarder_;
347 347
348 friend class DevToolsEventForwarder; 348 friend class DevToolsEventForwarder;
349 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 349 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
350 }; 350 };
351 351
352 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 352 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/tab_web_contents_delegate_android.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698