Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: components/guest_view/browser/guest_view_base.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
6 #define COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 6 #define COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <queue> 9 #include <queue>
10 10
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 bool exited) final; 357 bool exited) final;
358 void ContentsZoomChange(bool zoom_in) final; 358 void ContentsZoomChange(bool zoom_in) final;
359 void LoadingStateChanged(content::WebContents* source, 359 void LoadingStateChanged(content::WebContents* source,
360 bool to_different_document) final; 360 bool to_different_document) final;
361 content::ColorChooser* OpenColorChooser( 361 content::ColorChooser* OpenColorChooser(
362 content::WebContents* web_contents, 362 content::WebContents* web_contents,
363 SkColor color, 363 SkColor color,
364 const std::vector<content::ColorSuggestion>& suggestions) final; 364 const std::vector<content::ColorSuggestion>& suggestions) final;
365 void ResizeDueToAutoResize(content::WebContents* web_contents, 365 void ResizeDueToAutoResize(content::WebContents* web_contents,
366 const gfx::Size& new_size) final; 366 const gfx::Size& new_size) final;
367 void RunFileChooser(content::WebContents* web_contents, 367 void RunFileChooser(content::RenderFrameHost* render_frame_host,
368 const content::FileChooserParams& params) final; 368 const content::FileChooserParams& params) final;
369 bool ShouldFocusPageAfterCrash() final; 369 bool ShouldFocusPageAfterCrash() final;
370 void UpdatePreferredSize(content::WebContents* web_contents, 370 void UpdatePreferredSize(content::WebContents* web_contents,
371 const gfx::Size& pref_size) final; 371 const gfx::Size& pref_size) final;
372 void UpdateTargetURL(content::WebContents* source, const GURL& url) final; 372 void UpdateTargetURL(content::WebContents* source, const GURL& url) final;
373 bool ShouldResumeRequestsForCreatedWindow() final; 373 bool ShouldResumeRequestsForCreatedWindow() final;
374 374
375 // WebContentsObserver implementation. 375 // WebContentsObserver implementation.
376 void DidStopLoading() final; 376 void DidStopLoading() final;
377 void RenderViewReady() final; 377 void RenderViewReady() final;
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 // This is used to ensure pending tasks will not fire after this object is 479 // This is used to ensure pending tasks will not fire after this object is
480 // destroyed. 480 // destroyed.
481 base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_; 481 base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
482 482
483 DISALLOW_COPY_AND_ASSIGN(GuestViewBase); 483 DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
484 }; 484 };
485 485
486 } // namespace guest_view 486 } // namespace guest_view
487 487
488 #endif // COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 488 #endif // COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698