chrome/browser/android/tab_web_contents_delegate_android.h - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_web_contents_delegate_android.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/tab_web_contents_delegate_android.h

diff --git a/chrome/browser/android/tab_web_contents_delegate_android.h b/chrome/browser/android/tab_web_contents_delegate_android.h

index 9e4ceb418e620e46af9fbc60cd2c1ae0611f830c..7d6be85c64ffd84d308894668f5058e3da1bd6ca 100644

--- a/chrome/browser/android/tab_web_contents_delegate_android.h

+++ b/chrome/browser/android/tab_web_contents_delegate_android.h

@@ -40,7 +40,7 @@ class TabWebContentsDelegateAndroid

void LoadingStateChanged(content::WebContents* source,

bool to_different_document) override;

- void RunFileChooser(content::WebContents* web_contents,

+ void RunFileChooser(content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) override;

std::unique_ptr<content::BluetoothChooser> RunBluetoothChooser(

content::RenderFrameHost* frame,

« no previous file with comments | « apps/custom_launcher_page_contents.cc ('k') | chrome/browser/android/tab_web_contents_delegate_android.cc » ('j') | no next file with comments »