content/public/browser/web_contents_delegate.h - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/web_contents_delegate.h

diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h

index 74b56e15f708d78e8cf0fdf34ff2417bf4ad8632..2816c4da06cf5e90a5c49238f7420f2b172d2db2 100644

--- a/content/public/browser/web_contents_delegate.h

+++ b/content/public/browser/web_contents_delegate.h

@@ -341,7 +341,7 @@ class CONTENT_EXPORT WebContentsDelegate {

const std::vector<ColorSuggestion>& suggestions);

// Called when a file selection is to be done.

- virtual void RunFileChooser(WebContents* web_contents,

+ virtual void RunFileChooser(RenderFrameHost* render_frame_host,

const FileChooserParams& params) {}

// Request to enumerate a directory. This is equivalent to running the file

« no previous file with comments | « content/public/browser/render_frame_host.h ('k') | extensions/browser/app_window/app_delegate.h » ('j') | no next file with comments »