components/guest_view/browser/guest_view_base.h - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/guest_view/browser/guest_view_base.h

diff --git a/components/guest_view/browser/guest_view_base.h b/components/guest_view/browser/guest_view_base.h

index 17056d6fcc5c4302c36cfe904d8ffa80f386de4a..320a5e4d50b269831aeb861b657a7c3d3f4646df 100644

--- a/components/guest_view/browser/guest_view_base.h

+++ b/components/guest_view/browser/guest_view_base.h

@@ -364,7 +364,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

const std::vector<content::ColorSuggestion>& suggestions) final;

void ResizeDueToAutoResize(content::WebContents* web_contents,

const gfx::Size& new_size) final;

- void RunFileChooser(content::WebContents* web_contents,

+ void RunFileChooser(content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) final;

bool ShouldFocusPageAfterCrash() final;

void UpdatePreferredSize(content::WebContents* web_contents,

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »