Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/apps/chrome_app_delegate.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 614 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 void RendererUnresponsive(content::WebContents* source) override; 625 void RendererUnresponsive(content::WebContents* source) override;
626 void RendererResponsive(content::WebContents* source) override; 626 void RendererResponsive(content::WebContents* source) override;
627 void DidNavigateMainFramePostCommit( 627 void DidNavigateMainFramePostCommit(
628 content::WebContents* web_contents) override; 628 content::WebContents* web_contents) override;
629 content::JavaScriptDialogManager* GetJavaScriptDialogManager( 629 content::JavaScriptDialogManager* GetJavaScriptDialogManager(
630 content::WebContents* source) override; 630 content::WebContents* source) override;
631 content::ColorChooser* OpenColorChooser( 631 content::ColorChooser* OpenColorChooser(
632 content::WebContents* web_contents, 632 content::WebContents* web_contents,
633 SkColor color, 633 SkColor color,
634 const std::vector<content::ColorSuggestion>& suggestions) override; 634 const std::vector<content::ColorSuggestion>& suggestions) override;
635 void RunFileChooser(content::WebContents* web_contents, 635 void RunFileChooser(content::RenderFrameHost* render_frame_host,
636 const content::FileChooserParams& params) override; 636 const content::FileChooserParams& params) override;
637 void EnumerateDirectory(content::WebContents* web_contents, 637 void EnumerateDirectory(content::WebContents* web_contents,
638 int request_id, 638 int request_id,
639 const base::FilePath& path) override; 639 const base::FilePath& path) override;
640 bool EmbedsFullscreenWidget() const override; 640 bool EmbedsFullscreenWidget() const override;
641 void EnterFullscreenModeForTab(content::WebContents* web_contents, 641 void EnterFullscreenModeForTab(content::WebContents* web_contents,
642 const GURL& origin) override; 642 const GURL& origin) override;
643 void ExitFullscreenModeForTab(content::WebContents* web_contents) override; 643 void ExitFullscreenModeForTab(content::WebContents* web_contents) override;
644 bool IsFullscreenForTabOrPending( 644 bool IsFullscreenForTabOrPending(
645 const content::WebContents* web_contents) const override; 645 const content::WebContents* web_contents) const override;
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
1008 // The following factory is used for chrome update coalescing. 1008 // The following factory is used for chrome update coalescing.
1009 base::WeakPtrFactory<Browser> chrome_updater_factory_; 1009 base::WeakPtrFactory<Browser> chrome_updater_factory_;
1010 1010
1011 // The following factory is used to close the frame at a later time. 1011 // The following factory is used to close the frame at a later time.
1012 base::WeakPtrFactory<Browser> weak_factory_; 1012 base::WeakPtrFactory<Browser> weak_factory_;
1013 1013
1014 DISALLOW_COPY_AND_ASSIGN(Browser); 1014 DISALLOW_COPY_AND_ASSIGN(Browser);
1015 }; 1015 };
1016 1016
1017 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1017 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/apps/chrome_app_delegate.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698