Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: extensions/browser/app_window/app_delegate.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/web_contents_delegate.h ('k') | extensions/browser/app_window/app_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_delegate.h
diff --git a/extensions/browser/app_window/app_delegate.h b/extensions/browser/app_window/app_delegate.h
index 158b4469ed31ddacf2ada259a21a59e5310fa6c8..356f1ec740f5fa5921ac05293e2dc17a7c2e8b89 100644
--- a/extensions/browser/app_window/app_delegate.h
+++ b/extensions/browser/app_window/app_delegate.h
@@ -13,10 +13,11 @@
namespace content {
class BrowserContext;
class ColorChooser;
-struct FileChooserParams;
-struct OpenURLParams;
+class RenderFrameHost;
class RenderViewHost;
class WebContents;
+struct FileChooserParams;
+struct OpenURLParams;
}
namespace gfx {
@@ -58,7 +59,7 @@ class AppDelegate {
virtual content::ColorChooser* ShowColorChooser(
content::WebContents* web_contents,
SkColor initial_color) = 0;
- virtual void RunFileChooser(content::WebContents* tab,
+ virtual void RunFileChooser(content::RenderFrameHost* render_frame_host,
const content::FileChooserParams& params) = 0;
virtual void RequestMediaAccessPermission(
content::WebContents* web_contents,
« no previous file with comments | « content/public/browser/web_contents_delegate.h ('k') | extensions/browser/app_window/app_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698