chrome/browser/android/tab_web_contents_delegate_android.cc - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_web_contents_delegate_android.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/tab_web_contents_delegate_android.cc

diff --git a/chrome/browser/android/tab_web_contents_delegate_android.cc b/chrome/browser/android/tab_web_contents_delegate_android.cc

index ded591c5390d99b125d8450f2bd4af04592ee2e5..19d6e52a5c14e554aa37ec9b29783cb62a8c3a40 100644

--- a/chrome/browser/android/tab_web_contents_delegate_android.cc

+++ b/chrome/browser/android/tab_web_contents_delegate_android.cc

@@ -117,9 +117,9 @@ void TabWebContentsDelegateAndroid::LoadingStateChanged(

}

void TabWebContentsDelegateAndroid::RunFileChooser(

- WebContents* web_contents,

+ content::RenderFrameHost* render_frame_host,

const FileChooserParams& params) {

- FileSelectHelper::RunFileChooser(web_contents, params);

+ FileSelectHelper::RunFileChooser(render_frame_host, params);

}

std::unique_ptr<BluetoothChooser>

« no previous file with comments | « chrome/browser/android/tab_web_contents_delegate_android.h ('k') | chrome/browser/devtools/devtools_window.h » ('j') | no next file with comments »