extensions/browser/app_window/app_window.h - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/app_window/app_window.h

diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h

index dff9db27bb2dc57aa68e0ce82883b76148d1f00a..52c9034ad52ca0f1e4d6b1c56cf4a9945112a3a0 100644

--- a/extensions/browser/app_window/app_window.h

+++ b/extensions/browser/app_window/app_window.h

@@ -387,7 +387,7 @@ class AppWindow : public content::WebContentsDelegate,

content::WebContents* web_contents,

SkColor color,

const std::vector<content::ColorSuggestion>& suggestions) override;

- void RunFileChooser(content::WebContents* tab,

+ void RunFileChooser(content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) override;

bool IsPopupOrPanel(const content::WebContents* source) const override;

void MoveContents(content::WebContents* source,

« no previous file with comments | « extensions/browser/app_window/app_delegate.h ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »