content/browser/web_contents/web_contents_impl.cc - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_browsertest.cc ('k') | content/public/browser/render_frame_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index c49d37d16639fb29665be9c3acad59d8eded955a..93c38b001434283435e78155fff55cdf5df6811e 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -733,7 +733,7 @@ void WebContentsImpl::RunFileChooser(

RenderViewHost* render_view_host,

const FileChooserParams& params) {

if (delegate_)

- delegate_->RunFileChooser(this, params);

+ delegate_->RunFileChooser(GetMainFrame(), params);

}

NavigationControllerImpl& WebContentsImpl::GetController() {

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_browsertest.cc ('k') | content/public/browser/render_frame_host.h » ('j') | no next file with comments »