Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/app_window/app_window.h ('k') | extensions/shell/browser/shell_app_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 19f9a9b1bf86cfcc885af54766e4b20d153b9b0c..f3d2b98a37d92fd51fdf2eec21ceb2bd973fddbe 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -927,7 +927,7 @@ content::ColorChooser* AppWindow::OpenColorChooser(
return app_delegate_->ShowColorChooser(web_contents, initial_color);
}
-void AppWindow::RunFileChooser(WebContents* tab,
+void AppWindow::RunFileChooser(content::RenderFrameHost* render_frame_host,
const content::FileChooserParams& params) {
if (window_type_is_panel()) {
// Panels can't host a file dialog, abort. TODO(stevenjb): allow file
@@ -937,7 +937,7 @@ void AppWindow::RunFileChooser(WebContents* tab,
return;
}
- app_delegate_->RunFileChooser(tab, params);
+ app_delegate_->RunFileChooser(render_frame_host, params);
}
bool AppWindow::IsPopupOrPanel(const WebContents* source) const { return true; }
« no previous file with comments | « extensions/browser/app_window/app_window.h ('k') | extensions/shell/browser/shell_app_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698