extensions/shell/browser/shell_app_delegate.cc - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_app_delegate.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/browser/shell_app_delegate.cc

diff --git a/extensions/shell/browser/shell_app_delegate.cc b/extensions/shell/browser/shell_app_delegate.cc

index 6404964c6da1c1499d5488e3d09f5f6c5ca58461..5e5669d0a9babb20c6ce154174ba91b2f1195eb5 100644

--- a/extensions/shell/browser/shell_app_delegate.cc

+++ b/extensions/shell/browser/shell_app_delegate.cc

@@ -58,7 +58,7 @@ content::ColorChooser* ShellAppDelegate::ShowColorChooser(

}

void ShellAppDelegate::RunFileChooser(

- content::WebContents* tab,

+ content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) {

NOTIMPLEMENTED();

}

« no previous file with comments | « extensions/shell/browser/shell_app_delegate.h ('k') | no next file » | no next file with comments »