Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jshin+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr BUG=554298 R=rockot@chromium.org Committed: https://crrev.com/7c2ca35e78f7ba433da3eef399753148fe30f127 Cr-Commit-Position: refs/heads/master@{#389238}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+772 lines, -683 lines) Patch
M extensions/common/api/bluetooth/bluetooth_manifest_data.h View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_data.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_permission.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_permission.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M extensions/common/api/declarative/declarative_manifest_data.h View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/common/api/declarative/declarative_manifest_data.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M extensions/common/api/declarative/declarative_manifest_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/declarative/declarative_manifest_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_data.h View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_data.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/sockets/sockets_manifest_data.h View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_data.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.cc View 12 chunks +23 lines, -18 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission_unittest.cc View 7 chunks +47 lines, -43 lines 0 comments Download
M extensions/common/cast/cast_cert_validator.h View 3 chunks +3 lines, -4 lines 0 comments Download
M extensions/common/cast/cast_cert_validator.cc View 1 5 chunks +9 lines, -6 lines 0 comments Download
M extensions/common/cast/cast_cert_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/event_filter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/event_filter.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/event_filter_unittest.cc View 6 chunks +26 lines, -23 lines 0 comments Download
M extensions/common/event_filtering_info.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/event_filtering_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/event_matcher.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/event_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension.h View 7 chunks +8 lines, -8 lines 0 comments Download
M extensions/common/extension.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M extensions/common/extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_api.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M extensions/common/extension_builder.h View 3 chunks +6 lines, -4 lines 0 comments Download
M extensions/common/extension_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/extension_l10n_util.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/common/extension_l10n_util_unittest.cc View 16 chunks +19 lines, -17 lines 0 comments Download
M extensions/common/extension_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_messages.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M extensions/common/extension_set_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/common/extensions_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/features/base_feature_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/features/base_feature_provider.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/features/complex_feature.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/features/complex_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/features/complex_feature_unittest.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M extensions/common/features/feature_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/features/feature_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/features/json_feature_provider_source.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/features/simple_feature.h View 4 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/features/simple_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/features/simple_feature_unittest.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M extensions/common/file_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/file_util.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/common/file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/manifest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/manifest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handler_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handler_unittest.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M extensions/common/manifest_handlers/app_isolation_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/manifest_handlers/background_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/content_capabilities_handler.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/csp_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/manifest_handlers/default_locale_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/externally_connectable.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/externally_connectable.cc View 7 chunks +10 lines, -8 lines 0 comments Download
M extensions/common/manifest_handlers/file_handler_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/icons_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/icons_handler_unittest.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M extensions/common/manifest_handlers/incognito_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/manifest_handlers/kiosk_mode_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/launcher_page_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/mime_types_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/nacl_modules_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/oauth2_manifest_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/oauth2_manifest_unittest.cc View 16 chunks +26 lines, -25 lines 0 comments Download
M extensions/common/manifest_handlers/offline_enabled_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/manifest_handlers/options_page_info.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/options_page_info.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M extensions/common/manifest_handlers/permissions_parser.h View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/common/manifest_handlers/permissions_parser.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/common/manifest_handlers/requirements_info.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/requirements_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/sandboxed_page_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/shared_module_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/web_accessible_resources_info.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/webview_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/manifest_handlers/webview_info.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest_test.h View 4 chunks +7 lines, -7 lines 0 comments Download
M extensions/common/manifest_test.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M extensions/common/manifest_url_handlers.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M extensions/common/message_bundle.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/message_bundle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/api_permission_set_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M extensions/common/permissions/manifest_permission.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/manifest_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/manifest_permission_set.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/permissions/manifest_permission_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/media_galleries_permission_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/media_galleries_permission_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/permission_set.h View 1 chunk +6 lines, -5 lines 0 comments Download
M extensions/common/permissions/permission_set.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M extensions/common/permissions/set_disjunction_permission.h View 5 chunks +7 lines, -7 lines 0 comments Download
M extensions/common/permissions/settings_override_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/settings_override_permission.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/common/permissions/socket_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/socket_permission_data.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/socket_permission_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/permissions/socket_permission_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/socket_permission_unittest.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M extensions/common/permissions/usb_device_permission_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/usb_device_permission_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/stack_frame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/stack_frame.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M extensions/common/stack_frame_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/common/update_manifest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/url_pattern_set.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/url_pattern_set.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/common/url_pattern_set_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/url_pattern_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/common/value_builder.h View 5 chunks +8 lines, -8 lines 0 comments Download
M extensions/common/value_builder.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/common/value_builder_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/common/value_counter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/value_counter.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/shell/app/shell_main_delegate.h View 2 chunks +6 lines, -5 lines 0 comments Download
M extensions/shell/browser/api/identity/identity_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/api/identity/identity_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/api/identity/identity_api_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M extensions/shell/browser/media_capture_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.h View 3 chunks +17 lines, -15 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.h View 2 chunks +11 lines, -11 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/browser/shell_device_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_extension_system.h View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_native_app_window.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_native_app_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_native_app_window_aura_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_network_controller_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_network_controller_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_prefs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/browser/shell_prefs.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_prefs_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_screen_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.h View 2 chunks +7 lines, -6 lines 0 comments Download
M extensions/shell/test/shell_test.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/test/extensions_unittests_main.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/test/test_extensions_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/test/test_extensions_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
dcheng
+ fix for //extensions/test, since uses an //extensions/common interface as a base class.
4 years, 8 months ago (2016-04-21 17:44:10 UTC) #1
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-22 18:26:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908953003/1
4 years, 8 months ago (2016-04-22 18:27:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/55128) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 8 months ago (2016-04-22 18:33:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908953003/20001
4 years, 8 months ago (2016-04-22 18:44:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/189907)
4 years, 8 months ago (2016-04-22 19:03:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908953003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908953003/40001
4 years, 8 months ago (2016-04-22 19:38:15 UTC) #14
dcheng
+cc danakj
4 years, 8 months ago (2016-04-22 20:01:37 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-22 21:15:48 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 21:17:12 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7c2ca35e78f7ba433da3eef399753148fe30f127
Cr-Commit-Position: refs/heads/master@{#389238}

Powered by Google App Engine
This is Rietveld 408576698