Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: extensions/common/stack_frame.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/stack_frame.h ('k') | extensions/common/stack_frame_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/stack_frame.cc
diff --git a/extensions/common/stack_frame.cc b/extensions/common/stack_frame.cc
index 046a2652250e31f318f2afe620140c5f7c9940de..497edac45ea21381526d1521851c449d1ea3498f 100644
--- a/extensions/common/stack_frame.cc
+++ b/extensions/common/stack_frame.cc
@@ -45,7 +45,7 @@ StackFrame::~StackFrame() {
// (We have to recognize two formats because V8 will report stack traces in
// both ways. If we reconcile this, we can clean this up.)
// static
-scoped_ptr<StackFrame> StackFrame::CreateFromText(
+std::unique_ptr<StackFrame> StackFrame::CreateFromText(
const base::string16& frame_text) {
// We need to use utf8 for re2 matching.
std::string text = base::UTF16ToUTF8(frame_text);
@@ -60,13 +60,11 @@ scoped_ptr<StackFrame> StackFrame::CreateFromText(
!re2::RE2::FullMatch(text,
"([^\\(\\)]+):(\\d+):(\\d+)",
&source, &line, &column)) {
- return scoped_ptr<StackFrame>();
+ return std::unique_ptr<StackFrame>();
}
- return scoped_ptr<StackFrame>(new StackFrame(line,
- column,
- base::UTF8ToUTF16(source),
- base::UTF8ToUTF16(function)));
+ return std::unique_ptr<StackFrame>(new StackFrame(
+ line, column, base::UTF8ToUTF16(source), base::UTF8ToUTF16(function)));
}
bool StackFrame::operator==(const StackFrame& rhs) const {
« no previous file with comments | « extensions/common/stack_frame.h ('k') | extensions/common/stack_frame_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698