extensions/common/value_counter.h - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/value_counter.h

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/value_counter.h

diff --git a/extensions/common/value_counter.h b/extensions/common/value_counter.h

index b1137013fa9d34d5b4a8dd609d6022fb5cf0c2fd..f0a401d357db08a079439f9ce7a23600944b5503 100644

--- a/extensions/common/value_counter.h

+++ b/extensions/common/value_counter.h

@@ -5,10 +5,10 @@

#ifndef EXTENSIONS_COMMON_VALUE_COUNTER_H_

#define EXTENSIONS_COMMON_VALUE_COUNTER_H_

+#include <memory>

#include <vector>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

namespace base {

class Value;

@@ -42,7 +42,7 @@ class ValueCounter {

private:

struct Entry;

- std::vector<scoped_ptr<Entry>> entries_;

+ std::vector<std::unique_ptr<Entry>> entries_;

DISALLOW_COPY_AND_ASSIGN(ValueCounter);

};

« no previous file with comments | « extensions/common/value_builder_unittest.cc ('k') | extensions/common/value_counter.cc » ('j') | no next file with comments »