extensions/common/permissions/manifest_permission_set.cc - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/manifest_permission_set.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/manifest_permission.cc ('k') | extensions/common/permissions/manifest_permission_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/manifest_permission_set.cc

diff --git a/extensions/common/permissions/manifest_permission_set.cc b/extensions/common/permissions/manifest_permission_set.cc

index 39e2ba673d7522e4f1d9b27a014e45df5b3b7f94..383d125736dbaff7230b2fc3750bafc66e8ce737 100644

--- a/extensions/common/permissions/manifest_permission_set.cc

+++ b/extensions/common/permissions/manifest_permission_set.cc

@@ -28,8 +28,7 @@ bool CreateManifestPermission(

ManifestPermissionSet* manifest_permissions,

base::string16* error,

std::vector<std::string>* unhandled_permissions) {

- scoped_ptr<ManifestPermission> permission(

+ std::unique_ptr<ManifestPermission> permission(

ManifestHandler::CreatePermission(permission_name));

if (!permission) {