Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Side by Side Diff: extensions/common/update_manifest.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/stack_frame_unittest.cc ('k') | extensions/common/url_pattern_set.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/update_manifest.h" 5 #include "extensions/common/update_manifest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <memory>
8 9
9 #include "base/memory/scoped_ptr.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/version.h" 14 #include "base/version.h"
15 #include "libxml/tree.h" 15 #include "libxml/tree.h"
16 #include "third_party/libxml/chromium/libxml_utils.h" 16 #include "third_party/libxml/chromium/libxml_utils.h"
17 17
18 static const char* kExpectedGupdateProtocol = "2.0"; 18 static const char* kExpectedGupdateProtocol = "2.0";
19 static const char* kExpectedGupdateXmlns = 19 static const char* kExpectedGupdateXmlns =
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 std::string error; 278 std::string error;
279 if (!ParseSingleAppTag(apps[i], gupdate_ns, &current, &error)) { 279 if (!ParseSingleAppTag(apps[i], gupdate_ns, &current, &error)) {
280 ParseError("%s", error.c_str()); 280 ParseError("%s", error.c_str());
281 } else { 281 } else {
282 results_.list.push_back(current); 282 results_.list.push_back(current);
283 } 283 }
284 } 284 }
285 285
286 return true; 286 return true;
287 } 287 }
OLDNEW
« no previous file with comments | « extensions/common/stack_frame_unittest.cc ('k') | extensions/common/url_pattern_set.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698