extensions/common/permissions/usb_device_permission_data.h - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/usb_device_permission_data.h

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/socket_permission_unittest.cc ('k') | extensions/common/permissions/usb_device_permission_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/usb_device_permission_data.h

diff --git a/extensions/common/permissions/usb_device_permission_data.h b/extensions/common/permissions/usb_device_permission_data.h

index e72cc6c2b2a65564762eefafc2f3f358ca0c353c..a3e812991626c5c1c56cc28e663faf45b9fdcb89 100644

--- a/extensions/common/permissions/usb_device_permission_data.h

+++ b/extensions/common/permissions/usb_device_permission_data.h

@@ -6,9 +6,9 @@

#include <stdint.h>

+#include <memory>

#include <string>

-#include "base/memory/scoped_ptr.h"

#include "extensions/common/permissions/api_permission.h"

namespace base {

@@ -45,7 +45,7 @@ class UsbDevicePermissionData {

bool Check(const APIPermission::CheckParam* param) const;

// Convert |this| into a base::Value.

- scoped_ptr<base::Value> ToValue() const;

+ std::unique_ptr<base::Value> ToValue() const;

// Populate |this| from a base::Value.

bool FromValue(const base::Value* value);