extensions/shell/browser/api/identity/identity_api.cc - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/api/identity/identity_api.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/shell/browser/api/identity/identity_api.h ('k') | extensions/shell/browser/api/identity/identity_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/api/identity/identity_api.cc

diff --git a/extensions/shell/browser/api/identity/identity_api.cc b/extensions/shell/browser/api/identity/identity_api.cc

index ac3042750f3386e00b27984d25dbc105eab65b56..15564d6e51b4bc65490a5241b4faebf0c3d3795b 100644

--- a/extensions/shell/browser/api/identity/identity_api.cc

+++ b/extensions/shell/browser/api/identity/identity_api.cc

@@ -61,7 +61,7 @@ void IdentityGetAuthTokenFunction::SetMintTokenFlowForTesting(

}

ExtensionFunction::ResponseAction IdentityGetAuthTokenFunction::Run() {

- scoped_ptr<api::identity::GetAuthToken::Params> params(

+ std::unique_ptr<api::identity::GetAuthToken::Params> params(

api::identity::GetAuthToken::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

@@ -152,7 +152,7 @@ IdentityRemoveCachedAuthTokenFunction::

}

ExtensionFunction::ResponseAction IdentityRemoveCachedAuthTokenFunction::Run() {

- scoped_ptr<api::identity::RemoveCachedAuthToken::Params> params(

+ std::unique_ptr<api::identity::RemoveCachedAuthToken::Params> params(

api::identity::RemoveCachedAuthToken::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

// This stub identity API does not maintain a token cache, so there is nothing