extensions/common/api/declarative/declarative_manifest_data.h - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/declarative/declarative_manifest_data.h

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/api/bluetooth/bluetooth_manifest_permission.cc ('k') | extensions/common/api/declarative/declarative_manifest_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/declarative/declarative_manifest_data.h

diff --git a/extensions/common/api/declarative/declarative_manifest_data.h b/extensions/common/api/declarative/declarative_manifest_data.h

index d3147044d1915188c2a30126a09a7a8ed4556f52..dba174382278d3725373ea5d3cdaba908273b74a 100644

--- a/extensions/common/api/declarative/declarative_manifest_data.h

+++ b/extensions/common/api/declarative/declarative_manifest_data.h

@@ -30,8 +30,9 @@ class DeclarativeManifestData : public Extension::ManifestData {

// Tries to construct the info based on |value|, as it would have appeared in

// the manifest. Sets |error| and returns an empty scoped_ptr on failure.

- static scoped_ptr<DeclarativeManifestData> FromValue(const base::Value& value,

- base::string16* error);

+ static std::unique_ptr<DeclarativeManifestData> FromValue(

+ const base::Value& value,

+ base::string16* error);

std::vector<linked_ptr<DeclarativeManifestData::Rule>>& RulesForEvent(

const std::string& event);