Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: extensions/common/manifest_handlers/options_page_info.h

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLERS_OPTIONS_PAGE_INFO_H_ 5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLERS_OPTIONS_PAGE_INFO_H_
6 #define EXTENSIONS_COMMON_MANIFEST_HANDLERS_OPTIONS_PAGE_INFO_H_ 6 #define EXTENSIONS_COMMON_MANIFEST_HANDLERS_OPTIONS_PAGE_INFO_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 28 matching lines...) Expand all
39 static bool HasOptionsPage(const Extension* extension); 39 static bool HasOptionsPage(const Extension* extension);
40 40
41 // Returns whether the Chrome user agent stylesheet should be applied to the 41 // Returns whether the Chrome user agent stylesheet should be applied to the
42 // given extension's options page. 42 // given extension's options page.
43 static bool ShouldUseChromeStyle(const Extension* extension); 43 static bool ShouldUseChromeStyle(const Extension* extension);
44 44
45 // Returns whether the given extension's options page should be opened in a 45 // Returns whether the given extension's options page should be opened in a
46 // new tab instead of an embedded popup. 46 // new tab instead of an embedded popup.
47 static bool ShouldOpenInTab(const Extension* extension); 47 static bool ShouldOpenInTab(const Extension* extension);
48 48
49 static scoped_ptr<OptionsPageInfo> Create( 49 static std::unique_ptr<OptionsPageInfo> Create(
50 Extension* extension, 50 Extension* extension,
51 const base::Value* options_ui_value, 51 const base::Value* options_ui_value,
52 const std::string& options_page_string, 52 const std::string& options_page_string,
53 std::vector<InstallWarning>* install_warnings, 53 std::vector<InstallWarning>* install_warnings,
54 base::string16* error); 54 base::string16* error);
55 55
56 private: 56 private:
57 // The URL to the options page of this extension. We only store one options 57 // The URL to the options page of this extension. We only store one options
58 // URL, either options_page or options_ui.page. options_ui.page is preferred 58 // URL, either options_page or options_ui.page. options_ui.page is preferred
59 // if both are present. 59 // if both are present.
(...skipping 19 matching lines...) Expand all
79 79
80 private: 80 private:
81 const std::vector<std::string> Keys() const override; 81 const std::vector<std::string> Keys() const override;
82 82
83 DISALLOW_COPY_AND_ASSIGN(OptionsPageManifestHandler); 83 DISALLOW_COPY_AND_ASSIGN(OptionsPageManifestHandler);
84 }; 84 };
85 85
86 } // namespace extensions 86 } // namespace extensions
87 87
88 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLERS_OPTIONS_PAGE_INFO_H_ 88 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLERS_OPTIONS_PAGE_INFO_H_
OLDNEW
« no previous file with comments | « extensions/common/manifest_handlers/offline_enabled_info.cc ('k') | extensions/common/manifest_handlers/options_page_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698