extensions/common/permissions/manifest_permission.h - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/manifest_permission.h

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/api_permission_set_unittest.cc ('k') | extensions/common/permissions/manifest_permission.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/manifest_permission.h

diff --git a/extensions/common/permissions/manifest_permission.h b/extensions/common/permissions/manifest_permission.h

index db8f07c2594cb02c89bc688b4f36ce6fe30b3236..98e4c2306c3f00e4448bd086704bb1c1318bf6b7 100644

--- a/extensions/common/permissions/manifest_permission.h

+++ b/extensions/common/permissions/manifest_permission.h

@@ -5,10 +5,10 @@

#ifndef EXTENSIONS_COMMON_PERMISSIONS_MANIFEST_PERMISSION_H_

#define EXTENSIONS_COMMON_PERMISSIONS_MANIFEST_PERMISSION_H_

+#include <memory>

#include <string>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/pickle.h"

#include "extensions/common/permissions/api_permission_set.h"

@@ -45,7 +45,7 @@ class ManifestPermission {

virtual bool FromValue(const base::Value* value) = 0;

// Stores this into a new created Value.

- virtual scoped_ptr<base::Value> ToValue() const = 0;

+ virtual std::unique_ptr<base::Value> ToValue() const = 0;

// Clones this.

ManifestPermission* Clone() const;