Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/permissions/api_permission_set_unittest.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/permissions/api_permission_set.cc ('k') | extensions/common/permissions/manifest_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/api_permission_set_unittest.cc
diff --git a/extensions/common/permissions/api_permission_set_unittest.cc b/extensions/common/permissions/api_permission_set_unittest.cc
index 78a0161b27bd70df0b8983e89dd2d875da700018..b0acc83b141f0ce394de114300c1fd5d336f51ad 100644
--- a/extensions/common/permissions/api_permission_set_unittest.cc
+++ b/extensions/common/permissions/api_permission_set_unittest.cc
@@ -44,7 +44,7 @@ TEST(APIPermissionSetTest, CreateUnion) {
PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
@@ -79,7 +79,7 @@ TEST(APIPermissionSetTest, CreateUnion) {
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-send-to::8899"));
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
@@ -93,7 +93,7 @@ TEST(APIPermissionSetTest, CreateUnion) {
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
@@ -131,7 +131,7 @@ TEST(APIPermissionSetTest, CreateIntersection) {
apis1.insert(APIPermission::kDns);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
@@ -159,7 +159,7 @@ TEST(APIPermissionSetTest, CreateIntersection) {
apis2.insert(APIPermission::kSerial);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
value->Append(new base::StringValue("udp-send-to::8899"));
@@ -170,7 +170,7 @@ TEST(APIPermissionSetTest, CreateIntersection) {
expected_apis.insert(APIPermission::kAudioCapture);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
@@ -205,7 +205,7 @@ TEST(APIPermissionSetTest, CreateDifference) {
apis1.insert(APIPermission::kDns);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
@@ -225,7 +225,7 @@ TEST(APIPermissionSetTest, CreateDifference) {
apis2.insert(APIPermission::kSerial);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-send-to::8899"));
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
@@ -235,7 +235,7 @@ TEST(APIPermissionSetTest, CreateDifference) {
expected_apis.insert(APIPermission::kDns);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
@@ -268,7 +268,7 @@ TEST(APIPermissionSetTest, IPC) {
apis.insert(APIPermission::kDns);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
value->Append(new base::StringValue("udp-bind::8080"));
value->Append(new base::StringValue("udp-send-to::8888"));
« no previous file with comments | « extensions/common/permissions/api_permission_set.cc ('k') | extensions/common/permissions/manifest_permission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698