Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

extensions/common/extension_l10n_util_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_l10n_util.h"
 
+#include <memory>
+
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/linked_ptr.h"
-#include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension_paths.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/message_bundle.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 99 matching lines @@
   EXPECT_TRUE(locales.find("en_US") != locales.end());
 }
 
 TEST(ExtensionL10nUtil, LoadMessageCatalogsValidFallback) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &install_dir));
   install_dir =
       install_dir.AppendASCII("extension_with_locales").Append(kLocaleFolder);
 
   std::string error;
-  scoped_ptr<MessageBundle> bundle(extension_l10n_util::LoadMessageCatalogs(
-      install_dir, "sr", "en_US", &error));
+  std::unique_ptr<MessageBundle> bundle(
+      extension_l10n_util::LoadMessageCatalogs(install_dir, "sr", "en_US",
+                                               &error));
   ASSERT_FALSE(NULL == bundle.get());
   EXPECT_TRUE(error.empty());
   EXPECT_EQ("Color", bundle->GetL10nMessage("color"));
   EXPECT_EQ("Not in the US or GB.", bundle->GetL10nMessage("not_in_US_or_GB"));
 }
 
 TEST(ExtensionL10nUtil, LoadMessageCatalogsMissingFiles) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
@@ skipping 50 matching lines @@
 
   base::FilePath locale_2 = src_path.AppendASCII("sr");
   ASSERT_TRUE(base::CreateDirectory(locale_2));
 
   ASSERT_TRUE(base::WriteFile(
       locale_2.Append(kMessagesFilename), data.c_str(), data.length()));
 
   std::string error;
   // JSON parser hides duplicates. We are going to get only one key/value
   // pair at the end.
-  scoped_ptr<MessageBundle> message_bundle(
+  std::unique_ptr<MessageBundle> message_bundle(
       extension_l10n_util::LoadMessageCatalogs(src_path, "en", "sr", &error));
   EXPECT_TRUE(NULL != message_bundle.get());
   EXPECT_TRUE(error.empty());
 }
 
 // Caller owns the returned object.
 MessageBundle* CreateManifestBundle() {
   linked_ptr<base::DictionaryValue> catalog(new base::DictionaryValue);
 
   base::DictionaryValue* name_tree = new base::DictionaryValue();
@@ skipping 49 matching lines @@
   MessageBundle* bundle = MessageBundle::Create(catalogs, &error);
   EXPECT_TRUE(bundle);
   EXPECT_TRUE(error.empty());
 
   return bundle;
 }
 
 TEST(ExtensionL10nUtil, LocalizeEmptyManifest) {
   base::DictionaryValue manifest;
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_FALSE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
   EXPECT_EQ(std::string(errors::kInvalidName), error);
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithoutNameMsgAndEmptyDescription) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "no __MSG");
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("no __MSG", result);
 
   EXPECT_FALSE(manifest.HasKey(keys::kDescription));
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithNameMsgAndEmptyDescription) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "__MSG_name__");
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("name", result);
 
   EXPECT_FALSE(manifest.HasKey(keys::kDescription));
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithLocalLaunchURL) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "name");
   manifest.SetString(keys::kLaunchLocalPath, "__MSG_launch_local_path__");
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kLaunchLocalPath, &result));
   EXPECT_EQ("main.html", result);
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithHostedLaunchURL) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "name");
   manifest.SetString(keys::kLaunchWebURL, "__MSG_launch_web_url__");
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kLaunchWebURL, &result));
   EXPECT_EQ("http://www.google.com/", result);
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithBadNameMsg) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "__MSG_name_is_bad__");
   manifest.SetString(keys::kDescription, "__MSG_description__");
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_FALSE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("__MSG_name_is_bad__", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
   EXPECT_EQ("__MSG_description__", result);
 
   EXPECT_EQ("Variable __MSG_name_is_bad__ used but not defined.", error);
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithNameDescriptionDefaultTitleMsgs) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "__MSG_name__");
   manifest.SetString(keys::kDescription, "__MSG_description__");
   std::string action_title(keys::kBrowserAction);
   action_title.append(".");
   action_title.append(keys::kPageActionDefaultTitle);
   manifest.SetString(action_title, "__MSG_title__");
 
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("name", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
   EXPECT_EQ("description", result);
 
   ASSERT_TRUE(manifest.GetString(action_title, &result));
   EXPECT_EQ("action title", result);
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithNameDescriptionOmniboxMsgs) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "__MSG_name__");
   manifest.SetString(keys::kDescription, "__MSG_description__");
   manifest.SetString(keys::kOmniboxKeyword, "__MSG_omnibox_keyword__");
 
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("name", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
   EXPECT_EQ("description", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kOmniboxKeyword, &result));
   EXPECT_EQ("omnibox keyword", result);
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithNameDescriptionFileHandlerTitle) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "__MSG_name__");
   manifest.SetString(keys::kDescription, "__MSG_description__");
   base::ListValue* handlers = new base::ListValue();
   manifest.Set(keys::kFileBrowserHandlers, handlers);
   base::DictionaryValue* handler = new base::DictionaryValue();
   handlers->Append(handler);
   handler->SetString(keys::kPageActionDefaultTitle,
                      "__MSG_file_handler_title__");
 
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("name", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
   EXPECT_EQ("description", result);
@@ skipping 16 matching lines @@
   commands->Set("first_command", first_command);
   first_command->SetString(keys::kDescription,
                            "__MSG_first_command_description__");
 
   base::DictionaryValue* second_command = new base::DictionaryValue();
   commands->Set("second_command", second_command);
   second_command->SetString(keys::kDescription,
                             "__MSG_second_command_description__");
 
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("name", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
   EXPECT_EQ("description", result);
 
   ASSERT_TRUE(
       manifest.GetString("commands.first_command.description", &result));
   EXPECT_EQ("first command", result);
 
   ASSERT_TRUE(
       manifest.GetString("commands.second_command.description", &result));
   EXPECT_EQ("second command", result);
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithShortName) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "extension name");
   manifest.SetString(keys::kShortName, "__MSG_short_name__");
 
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
   EXPECT_TRUE(error.empty());
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kShortName, &result));
   EXPECT_EQ("short_name", result);
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithBadShortName) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "extension name");
   manifest.SetString(keys::kShortName, "__MSG_short_name_bad__");
 
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_FALSE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
   EXPECT_FALSE(error.empty());
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kShortName, &result));
   EXPECT_EQ("__MSG_short_name_bad__", result);
 }
 
@@ skipping 10 matching lines @@
   search_provider->SetString("suggest_url", "http://www.foo.__MSG_country__");
   manifest.Set(keys::kOverrideSearchProvider, search_provider);
 
   manifest.SetString(keys::kOverrideHomepage, "http://www.foo.__MSG_country__");
 
   base::ListValue* startup_pages = new base::ListValue;
   startup_pages->AppendString("http://www.foo.__MSG_country__");
   manifest.Set(keys::kOverrideStartupPage, startup_pages);
 
   std::string error;
-  scoped_ptr<MessageBundle> messages(CreateManifestBundle());
+  std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("name", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
   EXPECT_EQ("description", result);
@@ skipping 73 matching lines @@
   extension_l10n_util::GetAllFallbackLocales("en_US", "all", &fallback_locales);
   ASSERT_EQ(3U, fallback_locales.size());
 
   CHECK_EQ("en_US", fallback_locales[0]);
   CHECK_EQ("en", fallback_locales[1]);
   CHECK_EQ("all", fallback_locales[2]);
 }
 
 }  // namespace
 }  // namespace extensions