Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: extensions/common/stack_frame.h

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_STACK_FRAME_H_ 5 #ifndef EXTENSIONS_COMMON_STACK_FRAME_H_
6 #define EXTENSIONS_COMMON_STACK_FRAME_H_ 6 #define EXTENSIONS_COMMON_STACK_FRAME_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory>
10 #include <vector> 11 #include <vector>
11 12
12 #include "base/memory/scoped_ptr.h"
13 #include "base/strings/string16.h" 13 #include "base/strings/string16.h"
14 14
15 namespace extensions { 15 namespace extensions {
16 16
17 struct StackFrame { 17 struct StackFrame {
18 StackFrame(); 18 StackFrame();
19 StackFrame(const StackFrame& frame); 19 StackFrame(const StackFrame& frame);
20 StackFrame(uint32_t line_number, 20 StackFrame(uint32_t line_number,
21 uint32_t column_number, 21 uint32_t column_number,
22 const base::string16& source, 22 const base::string16& source,
23 const base::string16& function); 23 const base::string16& function);
24 ~StackFrame(); 24 ~StackFrame();
25 25
26 // Construct a stack frame from a reported plain-text frame. 26 // Construct a stack frame from a reported plain-text frame.
27 static scoped_ptr<StackFrame> CreateFromText( 27 static std::unique_ptr<StackFrame> CreateFromText(
28 const base::string16& frame_text); 28 const base::string16& frame_text);
29 29
30 bool operator==(const StackFrame& rhs) const; 30 bool operator==(const StackFrame& rhs) const;
31 31
32 // Note: we use uint32_t instead of size_t because this struct is sent over 32 // Note: we use uint32_t instead of size_t because this struct is sent over
33 // IPC which could span 32 & 64 bit processes. This is fine since line numbers 33 // IPC which could span 32 & 64 bit processes. This is fine since line numbers
34 // and column numbers shouldn't exceed UINT32_MAX even on 64 bit builds. 34 // and column numbers shouldn't exceed UINT32_MAX even on 64 bit builds.
35 uint32_t line_number; 35 uint32_t line_number;
36 uint32_t column_number; 36 uint32_t column_number;
37 base::string16 source; 37 base::string16 source;
38 base::string16 function; // optional 38 base::string16 function; // optional
39 }; 39 };
40 40
41 typedef std::vector<StackFrame> StackTrace; 41 typedef std::vector<StackFrame> StackTrace;
42 42
43 } // namespace extensions 43 } // namespace extensions
44 44
45 #endif // EXTENSIONS_COMMON_STACK_FRAME_H_ 45 #endif // EXTENSIONS_COMMON_STACK_FRAME_H_
46 46
OLDNEW
« no previous file with comments | « extensions/common/permissions/usb_device_permission_data.cc ('k') | extensions/common/stack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698