extensions/common/api/printer_provider/usb_printer_manifest_handler.cc - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/printer_provider/usb_printer_manifest_handler.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/api/printer_provider/usb_printer_manifest_data.cc ('k') | extensions/common/api/sockets/sockets_manifest_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/printer_provider/usb_printer_manifest_handler.cc

diff --git a/extensions/common/api/printer_provider/usb_printer_manifest_handler.cc b/extensions/common/api/printer_provider/usb_printer_manifest_handler.cc

index e356050b7e116491badda09cbf2b7022029ed061..eb6468f820120e3220e8451989d95dc286f11285 100644

--- a/extensions/common/api/printer_provider/usb_printer_manifest_handler.cc

+++ b/extensions/common/api/printer_provider/usb_printer_manifest_handler.cc

@@ -20,7 +20,7 @@ bool UsbPrinterManifestHandler::Parse(Extension* extension,

base::string16* error) {

const base::Value* usb_printers = nullptr;

CHECK(extension->manifest()->Get(manifest_keys::kUsbPrinters, &usb_printers));

- scoped_ptr<UsbPrinterManifestData> data =

+ std::unique_ptr<UsbPrinterManifestData> data =

UsbPrinterManifestData::FromValue(*usb_printers, error);

if (!data) {

return false;