Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: extensions/common/stack_frame_unittest.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/stack_frame.cc ('k') | extensions/common/update_manifest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/stack_frame_unittest.cc
diff --git a/extensions/common/stack_frame_unittest.cc b/extensions/common/stack_frame_unittest.cc
index 51f886774e596b73b2b1d4d8c320d271e03e8ca0..2fba51b9211f5f57e7b3705b4d101e2185c434c2 100644
--- a/extensions/common/stack_frame_unittest.cc
+++ b/extensions/common/stack_frame_unittest.cc
@@ -6,8 +6,9 @@
#include <stddef.h>
+#include <memory>
+
#include "base/logging.h"
-#include "base/memory/scoped_ptr.h"
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -24,7 +25,7 @@ void AssertStackFrameValid(const std::string& text,
const std::string& source,
const std::string& function) {
base::string16 utf16_text = base::UTF8ToUTF16(text);
- scoped_ptr<StackFrame> frame = StackFrame::CreateFromText(utf16_text);
+ std::unique_ptr<StackFrame> frame = StackFrame::CreateFromText(utf16_text);
ASSERT_TRUE(frame.get()) << "Failed to create frame from '" << text << "'";
EXPECT_EQ(line, frame->line_number);
@@ -35,7 +36,7 @@ void AssertStackFrameValid(const std::string& text,
void AssertStackFrameInvalid(const std::string& text) {
base::string16 utf16_text = base::UTF8ToUTF16(text);
- scoped_ptr<StackFrame> frame = StackFrame::CreateFromText(utf16_text);
+ std::unique_ptr<StackFrame> frame = StackFrame::CreateFromText(utf16_text);
ASSERT_FALSE(frame.get()) << "Errantly created frame from '" << text << "'";
}
« no previous file with comments | « extensions/common/stack_frame.cc ('k') | extensions/common/update_manifest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698