extensions/common/url_pattern_set.h - Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/url_pattern_set.h

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/url_pattern_set.h

diff --git a/extensions/common/url_pattern_set.h b/extensions/common/url_pattern_set.h

index 717779ced5d3fe570dc06d025ec1e63c79b833de..90b50f8bb36469a622215e621cf4a34ae5286ed5 100644

--- a/extensions/common/url_pattern_set.h

+++ b/extensions/common/url_pattern_set.h

@@ -8,9 +8,9 @@

#include <stddef.h>

#include <iosfwd>

+#include <memory>

#include <set>

-#include "base/memory/scoped_ptr.h"

#include "extensions/common/url_pattern.h"

class GURL;

@@ -99,14 +99,14 @@ class URLPatternSet {

bool OverlapsWith(const URLPatternSet& other) const;

// Converts to and from Value for serialization to preferences.

- scoped_ptr<base::ListValue> ToValue() const;

+ std::unique_ptr<base::ListValue> ToValue() const;

bool Populate(const base::ListValue& value,

int valid_schemes,

bool allow_file_access,

std::string* error);

// Converts to and from a vector of strings.

- scoped_ptr<std::vector<std::string> > ToStringVector() const;

+ std::unique_ptr<std::vector<std::string>> ToStringVector() const;

bool Populate(const std::vector<std::string>& patterns,

int valid_schemes,

bool allow_file_access,

« no previous file with comments | « extensions/common/update_manifest.cc ('k') | extensions/common/url_pattern_set.cc » ('j') | no next file with comments »