Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1709153002: Add more specialized fragment builders (Closed)

Created:
4 years, 10 months ago by Chris Dalton
Modified:
4 years, 10 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add more specialized fragment builders Adds specialized fragment builders for primitive and fragment processors. Removes fragment-specific functionality from the Xfer fragment builder. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709153002 Committed: https://skia.googlesource.com/skia/+/8528541dd7f09f5bd76f3f1ce5f45d08ac7347c7

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Make MSVC happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -148 lines) Patch
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAvoidXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 15 chunks +17 lines, -17 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrYUVEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 2 5 chunks +74 lines, -58 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLVarying.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Chris Dalton
This is strictly a refactor. The real changes are in GrGLSLFragmentShaderBuilder.*, everything else is just ...
4 years, 10 months ago (2016-02-18 18:14:06 UTC) #3
bsalomon
seems ok to me if it's ok to Greg
4 years, 10 months ago (2016-02-18 19:44:14 UTC) #4
egdaniel
this lgtm
4 years, 10 months ago (2016-02-18 19:57:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709153002/40001
4 years, 10 months ago (2016-02-18 19:57:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/6351)
4 years, 10 months ago (2016-02-18 20:00:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709153002/60001
4 years, 10 months ago (2016-02-18 20:10:45 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 20:37:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8528541dd7f09f5bd76f3f1ce5f45d08ac7347c7

Powered by Google App Engine
This is Rietveld 408576698