Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed)

Created:
5 years, 1 month ago by azani
Modified:
5 years, 1 month ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Require an explicit ServiceName annotation for interfaces in C++. ServiceName annotations were added only where currently needed. (used by C++ code only) The names added match the current implicit service names. BUG= #498 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f8fbb03675337f34373180cb2ed101b4c4fdde3d

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2 lines) Patch
M examples/apptest/example_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M examples/bank_app/bank.mojom View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M examples/echo/echo.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M examples/indirect_service/indirect_service_demo.mojom View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M examples/surfaces_app/child.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/versioning_test_client.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/versioning_test_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/data.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/asset_bundle/interfaces/asset_bundle.mojom View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/authenticating_url_loader_interceptor/interfaces/authenticating_url_loader_interceptor_meta_factory.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/authentication/interfaces/authentication.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/clipboard/interfaces/clipboard.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/contacts/interfaces/contacts.mojom View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/content_handler/interfaces/content_handler.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/device_info/interfaces/device_info.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/files/interfaces/files.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/gpu/interfaces/gpu.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/http_server/interfaces/http_server_factory.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/icu_data/interfaces/icu_data.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/keyboard/interfaces/keyboard.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/media/audio/interfaces/audio_server.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_support/interfaces/process.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/interfaces/native_viewport.mojom View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/navigation/interfaces/navigation.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/interfaces/network_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/nfc/interfaces/nfc.mojom View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/notifications/interfaces/notifications.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/prediction/interfaces/prediction.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/surfaces/interfaces/display.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/surfaces/interfaces/surfaces.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/terminal/interfaces/terminal.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/terminal/interfaces/terminal_client.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/tracing/interfaces/tracing.mojom View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/ui/views/interfaces/view_manager.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/ui/views/interfaces/view_provider.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/vanadium/security/interfaces/principal.mojom View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/interfaces/view_manager.mojom View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/window_manager/interfaces/window_manager.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/window_manager/interfaces/window_manager_internal.mojom View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M services/dart/test/interfaces/echo_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M services/dart/test/interfaces/pingpong_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M services/js/test/echo_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M services/js/test/network_test_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M services/js/test/pingpong_service.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M services/nacl/pnacl_compile.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M services/nacl/pnacl_link.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M services/native_viewport/native_viewport_support.mojom View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M services/test_service/test_request_tracker.mojom View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M services/test_service/test_service.mojom View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M shell/application_manager/test.mojom View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M shell/test/pingable.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
azani
ptal
5 years, 1 month ago (2015-11-19 21:34:05 UTC) #3
viettrungluu
LGTM w/an updated CL description: 1) Maybe say "ServiceName annotation" instead of just "ServiceName". 2) ...
5 years, 1 month ago (2015-11-19 21:44:20 UTC) #4
azani
5 years, 1 month ago (2015-11-19 22:04:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:2) manually as
f8fbb03675337f34373180cb2ed101b4c4fdde3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698